Automate upgrade using moved blocks
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
aknysh
reviewed
Oct 22, 2022
aknysh
previously approved these changes
Oct 22, 2022
nitrocode
reviewed
Oct 22, 2022
nitrocode
previously approved these changes
Oct 22, 2022
|
/test all |
nitrocode
previously approved these changes
Oct 23, 2022
|
/test all |
|
/test all |
nitrocode
reviewed
Oct 23, 2022
| } | ||
|
|
||
|
|
||
|
|
||
| locals { | ||
| deprecated_lifecycle_rule = { | ||
| enabled = var.lifecycle_rule_enabled | ||
| enabled = var.lifecycle_rule_enabled == true || (var.lifecycle_rule_enabled == null && length(var.lifecycle_configuration_rules) == 0) |
There was a problem hiding this comment.
Suggested change
| enabled = var.lifecycle_rule_enabled == true || (var.lifecycle_rule_enabled == null && length(var.lifecycle_configuration_rules) == 0) | |
| enabled = var.lifecycle_rule_enabled || (var.lifecycle_rule_enabled == null && length(var.lifecycle_configuration_rules) == 0) |
There was a problem hiding this comment.
│ Error: Operation failed
│
│ on variables-deprecated.tf line 82, in locals:
│ 82: enabled = var.lifecycle_rule_enabled || (var.lifecycle_rule_enabled == null && length(var.lifecycle_configuration_rules) == 0)
│ ├────────────────
│ │ var.lifecycle_rule_enabled is null
│
│ Error during operation: argument must not be null.
There was a problem hiding this comment.
ah interesting, I didn't realize if a var type = bool that defaulted to null wouldn't already implicitly resolve to false. Good to know.
nitrocode
approved these changes
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Notes
nullforce_destroyat its default value offalse, and if you have it set totruebut want extra safety against the S3 bucket being destroyed, set it tofalsebefore upgrading).force_destroy_enabledflag introduced in v0.27.0 has been removedlifecycle_configuration_rulesinput was introduced. In that version, you would continue to get the old default lifecycle rule even if you supplied new rules vialifecycle_configuration_rules. Now, the default behavior is to ignore all the deprecated lifecycle inputs when thelifecycle_configuration_rulesinput is not empty, unless you explicitly setlifecycle_rule_enabledto true.what
movedblock functionality introduced in Terraform 1.3.0nullable = falsefor module input variables which have a default value and where null is not a sensible/handled value for the variable.why
null, closes Support nullable flag for variables with default values #63